Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry up examples #3046

Open
wants to merge 83 commits into
base: refactor-coordinates
Choose a base branch
from
Open

Dry up examples #3046

wants to merge 83 commits into from

Conversation

tomc271
Copy link
Collaborator

@tomc271 tomc271 commented Dec 16, 2024

Extracted duplicated code to new class TokamakCoordinates that makes a Coordinates object for a tokamak system.

elm-pb
laplacexy/laplace_perp
gyro-gem example (using zero for I parameter)
alfven-wave example (using sinty for I parameter)
(rather than passing one to it for it to modify).
as `DataFileFacade.addOnce` method does not take const arguments.
because the function is marked const.
but need to copy value to a non-const variable to pass to `DataFileFacade.addOnce` method.
tomchapman and others added 30 commits December 16, 2024 19:11
…k_coordinates_factory.make_tokamak_coordinates()"
class `TokamakCoordinatesFactory` renamed to `TokamakCoordinates`
method `tokamak_coordinates_factory` renamed to `tokamak_coordinates`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants